Skip to content

build: remove no-op _native_rules_allowlist #3275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 17, 2025
Merged

build: remove no-op _native_rules_allowlist #3275

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
30d1d29
remove no-op _native_rules_allowlist
mai93 Sep 16, 2025
fc26702
Remove unused _PackageSpecificationInfo
mai93 Sep 16, 2025
ee4e15e
Remove unused py_internal load
mai93 Sep 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 0 additions & 27 deletions python/private/attributes.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,12 +21,9 @@ load(":common_labels.bzl", "labels")
load(":enum.bzl", "enum")
load(":flags.bzl", "PrecompileFlag", "PrecompileSourceRetentionFlag")
load(":py_info.bzl", "PyInfo")
load(":py_internal.bzl", "py_internal")
load(":reexports.bzl", "BuiltinPyInfo")
load(":rule_builders.bzl", "ruleb")

_PackageSpecificationInfo = getattr(py_internal, "PackageSpecificationInfo", None)

# Due to how the common exec_properties attribute works, rules must add exec
# groups even if they don't actually use them. This is due to two interactions:
# 1. Rules give an error if users pass an unsupported exec group.
Expand Down Expand Up @@ -174,33 +171,9 @@ This is because Python has a concept of runtime resources.
),
}

def _create_native_rules_allowlist_attrs():
if py_internal:
# The fragment and name are validated when configuration_field is called
default = configuration_field(
fragment = "py",
name = "native_rules_allowlist",
)

# A None provider isn't allowed
providers = [_PackageSpecificationInfo]
else:
default = None
providers = []

return {
"_native_rules_allowlist": lambda: attrb.Label(
default = default,
providers = providers,
),
}

NATIVE_RULES_ALLOWLIST_ATTRS = _create_native_rules_allowlist_attrs()

# Attributes common to all rules.
COMMON_ATTRS = dicts.add(
DATA_ATTRS,
NATIVE_RULES_ALLOWLIST_ATTRS,
# buildifier: disable=attr-licenses
{
# NOTE: This attribute is deprecated and slated for removal.
Expand Down
2 changes: 0 additions & 2 deletions python/private/py_runtime_rule.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@
load("@bazel_skylib//lib:dicts.bzl", "dicts")
load("@bazel_skylib//lib:paths.bzl", "paths")
load("@bazel_skylib//rules:common_settings.bzl", "BuildSettingInfo")
load(":attributes.bzl", "NATIVE_RULES_ALLOWLIST_ATTRS")
load(":common_labels.bzl", "labels")
load(":flags.bzl", "FreeThreadedFlag")
load(":py_internal.bzl", "py_internal")
Expand Down Expand Up @@ -191,7 +190,6 @@ py_runtime(
""",
fragments = ["py"],
attrs = dicts.add(
{k: v().build() for k, v in NATIVE_RULES_ALLOWLIST_ATTRS.items()},
{
"abi_flags": attr.string(
default = "<AUTO>",
Expand Down