Skip to content

Conversation

rickeylev
Copy link
Collaborator

The original PR omitted the target from the docs, so it was absent.

Along the way, fix some incorrect deps for its target so docs build.

@rickeylev rickeylev requested a review from aignas as a code owner September 29, 2025 03:15
Copy link
Contributor

Summary of Changes

Hello @rickeylev, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses an oversight where the config bzlmod extension was not included in the generated documentation. It rectifies this by adding the necessary target to the documentation build configuration. Additionally, it resolves underlying dependency issues that were preventing the documentation from building correctly, ensuring a complete and functional documentation output.

Highlights

  • Documentation Update: The config bzlmod extension has been explicitly added to the documentation generation process, ensuring its presence in the generated docs.
  • Dependency Correction: Incorrect dependencies for the internal_config_repo_bzl target have been fixed, replacing :bzlmod_enabled_bzl with :repo_utils_bzl and :text_util_bzl to ensure proper build functionality for the documentation.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds documentation for the config.bzl bzlmod extension and fixes a dependency issue to enable the documentation build. The changes are correct and look good. The new documentation target is added in alphabetical order, and the dependency fix in python/private/BUILD.bazel correctly reflects the loads in internal_config_repo.bzl.

@rickeylev rickeylev added this pull request to the merge queue Sep 29, 2025
Merged via the queue into bazel-contrib:main with commit c4935b1 Sep 29, 2025
4 checks passed
@rickeylev rickeylev deleted the docs.add.config.ext.docs branch September 29, 2025 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants