rules_python_external: fill missing docstrings #358
Conversation
| url = url, | ||
| sha256 = sha256, | ||
| type = "zip", | ||
| build_file_content = _GENERIC_WHEEL, |
There was a problem hiding this comment.
From running buildifier on file.
There was a problem hiding this comment.
we should add a task to make that automated (I like to do it as a git pre-commit hook so you don't need to think about it)
| """, | ||
| ) | ||
|
|
||
| def pip_install(requirements, name = DEFAULT_REPOSITORY_NAME, **kwargs): |
There was a problem hiding this comment.
This is a really thin macro. Not doing much at all.
There was a problem hiding this comment.
yeah in my PR to promote to public API, I use this as a spot to add the fetch of external repos like pypi__pip
| """, | ||
| ) | ||
|
|
||
| def pip_install(requirements, name = DEFAULT_REPOSITORY_NAME, **kwargs): |
There was a problem hiding this comment.
yeah in my PR to promote to public API, I use this as a spot to add the fetch of external repos like pypi__pip
| url = url, | ||
| sha256 = sha256, | ||
| type = "zip", | ||
| build_file_content = _GENERIC_WHEEL, |
There was a problem hiding this comment.
we should add a task to make that automated (I like to do it as a git pre-commit hook so you don't need to think about it)
alexeagle
deleted the
jonathon--rules_python_external-fill-missing-docstrings-sep2020
branch
3 participants
Description
Adding missing docstrings for
experimental/rules_python_external. Does not add new rules into Stardoc yet. That will be a subsequent pull request.Plan 🛣
Our plan is in multiple steps:
bring in the repo to a subdirectory, preserving git history and contributorsclean up the code, remove mypy, get it functional in that subdirectoryadd an example/integration test proving that it workscut a patch release and get some users to test it outPR Checklist
Please check if your PR fulfills the following requirements:
.parfiles. See CONTRIBUTING.md for infoDoes this PR introduce a breaking change?