Skip to content

Conversation

pstradomski
Copy link
Contributor

@pstradomski pstradomski commented Oct 4, 2020

Minor cleanups:

  • rename experimental/rules_python to experimental/tools to avoid confusion,
  • change "generator" header in distinfo/WHEEL to be more informative.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Does not include precompiled binaries, eg. .par files. See CONTRIBUTING.md for info
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature (please, look at the "Scope of the project" section in the README.md file)
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Minor cleanups

What is the new behavior?

Change in "generator" header in distinfo/WHEEL

Does this PR introduce a breaking change?

  • Yes
  • No

This better reflects contents of this package.
It will be easier to identify origin of the wheels.
Copy link

@thundergolfer thundergolfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pstradomski pstradomski merged commit c639955 into bazel-contrib:master Oct 14, 2020
@pstradomski pstradomski deleted the cleanups branch October 14, 2020 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants