Skip to content

Conversation

ducthienbui97
Copy link
Contributor

Currently CONTRIBUTING.md links to /CONTRIBUTING.md, it's fine for markdown rendering but in the PR, it links to https://github.com/contributing.md instead

PR Checklist

Please check if your PR fulfills the following requirements:

  • Does not include precompiled binaries, eg. .par files. See CONTRIBUTING.md for info
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature (please, look at the "Scope of the project" section in the README.md file)
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • [ x] No

Other information

Currently `CONTRIBUTING.md` links to `/CONTRIBUTING.md`, it's fine for markdown rendering but in the PR, it links to https://github.com/contributing.md instead
Copy link

@thundergolfer thundergolfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Bit of a wart in Github.

@thundergolfer thundergolfer merged commit dd8b148 into bazel-contrib:master Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants