Skip to content

Conversation

thundergolfer
Copy link

PR Checklist

Please check if your PR fulfills the following requirements:

  • Does not include precompiled binaries, eg. .par files. See CONTRIBUTING.md for info
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature (please, look at the "Scope of the project" section in the README.md file)
  • Code style update (formatting, local variables)
  • [] Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

Description

This TODO was introduced here: brandjon@29260b3

I figure this TODO is now well obsolete and we can undo it. CI should still pass, and it does.

Note: I don't know why it shouldn't just be //... instead of .... Both work in CI, but bazel build ... is invalid when run locally.

Does this PR introduce a breaking change?

  • Yes
  • No

cc @brandjon

@thundergolfer thundergolfer requested a review from andyscott as a code owner March 2, 2021 10:56
@google-cla google-cla bot added the cla: yes label Mar 2, 2021
Copy link
Contributor

@hrfuller hrfuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@thundergolfer thundergolfer merged commit c37ba22 into master Mar 11, 2021
@thundergolfer thundergolfer deleted the jonathon--remove-TODO-in-CI-presubmit-mar2021 branch March 11, 2021 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants