Skip to content

Conversation

thundergolfer
Copy link

🧹 🧹 ...

Just removing a TODO we don't need anymore. We not longer use a deps() function to included dependencies and bazelbuild/rules_pkg#72 shows that it's no longer a desired pattern.


PR Checklist

Please check if your PR fulfills the following requirements:

  • Does not include precompiled binaries, eg. .par files. See CONTRIBUTING.md for info
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature (please, look at the "Scope of the project" section in the README.md file)
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

cc @brandjon

@thundergolfer thundergolfer requested a review from andyscott as a code owner March 2, 2021 11:11
@google-cla google-cla bot added the cla: yes label Mar 2, 2021
@thundergolfer thundergolfer requested a review from hrfuller March 3, 2021 23:10
Copy link
Contributor

@hrfuller hrfuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thundergolfer thundergolfer merged commit fd31d2c into master Mar 4, 2021
@thundergolfer thundergolfer deleted the jonathon--remove-TODO-in-distro-about-release-notes-mar2021 branch March 4, 2021 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants