Skip to content

Use BUILD.bazel file when creating py_library rules of extracted whls #427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 3, 2021
Merged

Use BUILD.bazel file when creating py_library rules of extracted whls #427

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8aca11d
Use BUILD.bazel file when creating py_library rules of extracted whls
Mar 2, 2021
fc6e631
update tests
Mar 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions python/pip_install/extract_wheels/lib/bazel.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ def generate_build_file_contents(
there may be no Python sources whatsoever (e.g. packages written in Cython: like `pymssql`).
"""

data_exclude = ["*.whl", "**/*.py", "**/* *", "BUILD", "WORKSPACE"] + pip_data_exclude
data_exclude = ["*.whl", "**/*.py", "**/* *", "BUILD.bazel", "WORKSPACE"] + pip_data_exclude

return textwrap.dedent(
"""\
Expand Down Expand Up @@ -184,7 +184,7 @@ def extract_wheel(
'"//%s:%s"' % (sanitise_name(d), WHEEL_FILE_LABEL) for d in whl_deps
]

with open(os.path.join(directory, "BUILD"), "w") as build_file:
with open(os.path.join(directory, "BUILD.bazel"), "w") as build_file:
contents = generate_build_file_contents(
sanitise_name(whl.name), sanitised_dependencies, sanitised_wheel_file_dependencies, pip_data_exclude
)
Expand Down
2 changes: 1 addition & 1 deletion python/pip_install/extract_wheels/lib/whl_filegroup_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ def test_generated_build_file_has_filegroup_target(self) -> None:
)[2:] # Take off the leading // from the returned label.
# Assert that the raw wheel ends up in the package.
self.assertIn(wheel_name, os.listdir(generated_bazel_dir))
with open("{}/BUILD".format(generated_bazel_dir)) as build_file:
with open("{}/BUILD.bazel".format(generated_bazel_dir)) as build_file:
build_file_content = build_file.read()
self.assertIn('filegroup', build_file_content)

Expand Down