Skip to content

Add tags pypi_name and pypi_version to generated py_library targets #530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 21, 2021
Merged

Add tags pypi_name and pypi_version to generated py_library targets #530

merged 1 commit into from
Sep 21, 2021

Conversation

alexeagle
Copy link
Contributor

@alexeagle alexeagle commented Sep 8, 2021 •
edited by thundergolfer
Loading

This allows tooling to use a bazel query to reverse-engineer a requirements.txt from a transitive closure of a py_binary

PR Checklist

Please check if your PR fulfills the following requirements:

  • Does not include precompiled binaries, eg. .par files. See CONTRIBUTING.md for info
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature (please, look at the "Scope of the project" section in the README.md file)
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@google-cla google-cla bot added the cla: yes label Sep 8, 2021
@thundergolfer thundergolfer requested review from thundergolfer and removed request for brandjon and lberki September 14, 2021 07:28
thundergolfer
thundergolfer approved these changes Sep 14, 2021
View reviewed changes
hrfuller
hrfuller reviewed Sep 18, 2021
View reviewed changes
Copy link
Contributor

@hrfuller hrfuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple nits.

@alexeagle alexeagle requested a review from mattem September 20, 2021 03:14
@alexeagle
Add tags pypi_name and pypi_version to generated py_library targets
f9b57a0 
This allows tooling to use a bazel query to reverse-engineer a requirements.txt from a transitive closure of a py_binary
@alexeagle
Copy link
Contributor Author

Added an assertion using genquery in one of the examples as well.

@alexeagle alexeagle merged commit c303849 into bazel-contrib:main Sep 21, 2021
@alexeagle alexeagle deleted the pypi_metadata_tags branch September 21, 2021 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyscott andyscott Awaiting requested review from andyscott

@mattem mattem Awaiting requested review from mattem

2 more reviewers

@hrfuller hrfuller hrfuller left review comments

@thundergolfer thundergolfer thundergolfer approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexeagle @hrfuller @thundergolfer