Skip to content

Conversation

mattem
Copy link
Contributor

@mattem mattem commented Feb 1, 2022

This bumps the version of bazel used locally when building to 4.2.0. This version is the first bazel version in 4.x that supports M1 correctly.
This bump doesn't change what is expected from users. However, should it?

@alexeagle
Copy link
Contributor

Let's go to 4.2.2 and also update version.bzl ?

@thundergolfer thundergolfer removed the request for review from andyscott February 8, 2022 09:47
@thundergolfer
Copy link

thundergolfer commented Feb 8, 2022

@mattem

However, should it?

Yeh the version.bzl says as much, originally written by Alex 🙂

# This version should be updated together with the version of the Bazel
# in .bazelversion.

(we can delete that last "the" in the first line)

@mattem
Copy link
Contributor Author

mattem commented Feb 11, 2022

Yeah, I'm familiar with the semantics (and the typo) from rnj, my question was more do we want to now bump the minimum supported version for rules_python to 4.2.2, or do we want to test against an array of versions (which will be slower on CI here). Sounds like the consensus is to bump it.

@f0rmiga f0rmiga merged commit 83f9154 into bazel-contrib:main Feb 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants