Skip to content

Conversation

UebelAndre
Copy link
Contributor

@UebelAndre UebelAndre commented Feb 25, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature (please, look at the "Scope of the project" section in the README.md file)
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

If a compile_pip_requirements target is setup in a separate package than where the requirements_in file is located, then an incorrect custom compile command is written into the requirements_txt file.

Issue Number: N/A

What is the new behavior?

This change fixes that so no matter where the compile_pip_requirements target is defined, it will always correctly be reflected in the generated files when running the *.update target.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@UebelAndre UebelAndre marked this pull request as ready for review February 25, 2022 00:48
@f0rmiga f0rmiga merged commit c6357a6 into bazel-contrib:main Feb 25, 2022
@UebelAndre UebelAndre deleted the compile branch February 25, 2022 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants