linux-arm64 python binary support #669
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lazcamus
requested review from
brandjon,
lberki and
thundergolfer
as code owners
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). For more information, open the CLA check for this pull request. |
lazcamus
force-pushed
the
linux-arm64-support
branch
from
a5c4628 to
1adaaed
Compare
* add aarch64-unknown-linux-gnu python binary release
* unittests run & pass on my m1 macbook in OSX and Linux
* Note: most //examples/... tests fail when run due to lack of support
for non-x86 in https://github.com/bazelbuild/bazel-integration-testing/,
but those failing tests pass when run directly in the directory with
bazel
lazcamus
force-pushed
the
linux-arm64-support
branch
from
1adaaed to
f6b6c58
Compare
|
just tested this out on a PR im working on (here envoyproxy/envoy#20432) and this fixes the arm build for us would be great if this was landed (thanks @lazcamus ) |
f0rmiga
approved these changes
Apr 8, 2022
| for platform in TOOL_VERSIONS[python_version]["sha256"].keys() | ||
| ]) | ||
|
|
||
| def gen_python_config_settings(name = ""): |
There was a problem hiding this comment.
It's nice to have everything tidied up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
On linux arm64, rules_python using the precompiled python toolchain fails:
Issue Number: N/A
What is the new behavior?
It works on Linux arm64 now.
rules_pythontests pass on an m1 macbook pro in both OSX and Linux.Some tests on linux-arm64 fail because bazel-integration-testing is x86 only. Here's a test.log that includes running the failed tests.
Funnily, these tests all pass on aarch64 OSX because of x86 binary emulation.
Does this PR introduce a breaking change?
Other information
I added
gen_python_config_settings()topython/versions.bzlto avoid duplicating the constraints that were already codified in the file. I don't think it'd get much (any) use? I think mostrules_pythonusers would already have this style stuff setup in their repo ... though maybe I'm just biased by the monorepo I'm working on this for.