Handle entry_points that end with .py #702
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thundergolfer
approved these changes
May 18, 2022
| (directory_path / entry_point_script).write_text( | ||
| # There is an extreme edge-case with entry_points that end with `.py` | ||
| # See: https://github.com/bazelbuild/bazel/blob/09c621e4cf5b968f4c6cdf905ab142d5961f9ddc/src/test/java/com/google/devtools/build/lib/rules/python/PyBinaryConfiguredTargetTest.java#L174 | ||
| entry_point_without_py = name[:-3] if name.endswith(".py") else name |
There was a problem hiding this comment.
Suggested change
| entry_point_without_py = name[:-3] if name.endswith(".py") else name | |
| entry_point_without_py = name.removesuffix(".py") |
https://docs.python.org/3/library/stdtypes.html#str.removesuffix
There was a problem hiding this comment.
Incredible as it may seem , that is New in version 3.9. and I would prefer this to be compatible with older versions of PY3.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
There are some entry_points in the wild that end with a
.pysuffix. This is an extreme edge-case, but this clashes with the native Python rules in Bazel that forbidspy_binaryto end with.py.Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information
An example entry_point in the wild that ends with
.pyhttps://github.com/jupyterhub/jupyterhub-idle-culler/blob/9dba16033485f3c70352edd3255bb0c5905f16ce/setup.py#L15