Skip to content

Conversation

groodt
Copy link
Collaborator

@groodt groodt commented Jun 28, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature (please, look at the "Scope of the project" section in the README.md file)
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

The experimental folder re-exports functionality and has done so for a long-time. Perhaps this has been long-enough and no longer needs to exist? I don't feel too strongly about removing this, but it does seem like noise that could easily be restored if necessary.

What is the new behavior?

Removes the //experimental folder because everything has graduated out of it.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@groodt groodt marked this pull request as ready for review June 28, 2022 13:14
@groodt groodt requested a review from thundergolfer as a code owner June 28, 2022 13:14
@alexeagle alexeagle merged commit 5c6661e into bazel-contrib:main Jun 28, 2022
mattem pushed a commit to mattem/rules_python that referenced this pull request Jul 7, 2022
Co-authored-by: Alex Eagle <alex@aspect.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants