Skip to content

Conversation

groodt
Copy link
Collaborator

@groodt groodt commented Aug 1, 2022

Updates pip from 22.1.2 to 22.2.1. See Changelog. This version is backwards compatible and no new functionality is introduced to the rules.


Something to keep an eye on is that an experimental feature has been added to prepare an "installation report".
pip install --dry-run --ignore-installed --report

This approximates lock-file-like functionality, however, the maintainers explicitly mention that it is not intended to be a lock-file and it is experimental functionality. Even so, it may enable us to remove a dependency on pip-tools at some stage. This would be nice because it could eventually strip the rules back to only the Python standard library and pip. Or it could become the bones of a custom resolver.

@groodt groodt requested review from brandjon and lberki as code owners August 1, 2022 10:46
@groodt groodt requested review from alexeagle, hrfuller and mattem and removed request for brandjon and lberki August 1, 2022 14:28
@groodt groodt requested a review from thundergolfer August 1, 2022 14:29
Copy link
Contributor

@alexeagle alexeagle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I think we should periodically bump our dependencies to latest.

FWIW if we did go down the path of a custom resolver, I'd hope we could re-use someone elses (like the one in Pants) rather than actually write one

@alexeagle alexeagle merged commit ac5b973 into main Aug 1, 2022
@hrfuller
Copy link
Contributor

hrfuller commented Aug 1, 2022

(like the one in Pants)

Which resolver are you referring to? AFAIK PEX is used to build python distributions in pants, and PEX subprocesses out to pip to do resolves. Is there another place where python resolves are done in a custom way?

@alexeagle alexeagle deleted the groodt-bump-pip branch May 23, 2023 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants