Correctly reference os-specific labels from central alias repo #889
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current aliases hardcode the bazel host os, which does not work when cross compiling. For example, when building for linux from bazel running macos, referencing @python3_9//:libpython would reference the macos library, not the linux one.
PR Checklist
Please check if your PR fulfills the following requirements:
I don't know this can be tested without cross compile infrastructure set up in this repo. Existing tests should verify that it continues to work when not cross compiling.
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The main repository alias references only the host platform.
What is the new behavior?
Using labels from the central repository will correctly reference the python toolchain corresponding to the current target/exec platform.
Does this PR introduce a breaking change?
Other information