Skip to content

Conversation

rbuckland
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature (please, look at the "Scope of the project" section in the README.md file)
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #895

What is the new behavior?

rpyc dependency generates separate py_binary rules.

Does this PR introduce a breaking change?

  • Yes
  • No
  • Unsure

Other information

@rbuckland rbuckland requested a review from hrfuller as a code owner November 23, 2022 02:35
@alexeagle
Copy link
Contributor

My understanding is that this is breaking, yes. Users may have to add back the _py suffix if they're already using one of these. But it was documented as an "extreme edge case" and you're right that removing .py suffix is a recipe for collisions, so I think this is okay. Thanks!

@alexeagle alexeagle merged commit b69431e into bazel-contrib:main Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants