Skip to content

Conversation

fmeum
Copy link
Member

@fmeum fmeum commented Jan 12, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature (please, look at the "Scope of the project" section in the README.md file)
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Docs reference bazel_tools and import instructions fail with Bzlmod.

What is the new behavior?

The canonical location for the runfiles library going forward will be the rules_python repo, so users should load from it. Since repository names are essentially dynamic with Bzlmod, they should not be used in import statements.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

The canonical location for the runfiles library going forward will be
the rules_python repo, so users should load from it. Since repository
names are essentially dynamic with Bzlmod, they should not be used in
import statements.
@fmeum fmeum requested a review from rickeylev as a code owner January 12, 2023 14:59
@fmeum
Copy link
Member Author

fmeum commented Jan 12, 2023

CC @alexeagle

@alexeagle alexeagle merged commit c988c0a into bazel-contrib:main Jan 18, 2023
@fmeum fmeum deleted the runfiles-fix-import branch January 19, 2023 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants