Skip to content

Conversation

linzhp
Copy link
Contributor

@linzhp linzhp commented Jan 18, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature (please, look at the "Scope of the project" section in the README.md file)
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Gazelle extension uses std_modules and parser without declaring them as runtime dependencies, causing errors like:

2023/01/18 16:08:23 failed to initialize std_modules: Runfile gazelle/std_modules: could not locate file

What is the new behavior?

Adding them to the data attribute of Gazelle extension

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@linzhp linzhp requested a review from f0rmiga as a code owner January 18, 2023 17:09
@f0rmiga f0rmiga merged commit 8081ca6 into bazel-contrib:main Jan 23, 2023
@linzhp linzhp deleted the data branch January 23, 2023 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants