Remove usage of scala_export_to_java #1085
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
scala_export_to_javawas removed in https://github.com/bazelbuild/rules_scala/pull/227/files#diff-9957b181001dad28e385437a86e99126L788 but is still used inrules_scala/test_expect_failure/transitive/java_to_scala/BUILDbazel build test_expect_failure/transitive/java_to_scala:dwas indeed failing but for different reason than expected. However currenttest_transitive_depswas passing because it checks only exit code and not exact reason. I tried to tighten assertion but not really sure about proposed bash changes.Motivation
I tried to open repository with vscode which queried bazel build targets with
bazel query ...:* --output=packageand that failed withfile '//scala:scala.bzl' does not contain symbol 'scala_export_to_java'