Fix action_should_fail_with_message sh helper #1198
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add missing `exit 1` to make test actaully fail Had to remove `jvm_opts = ["-Xbootclasspath/p:$(location @bazel_tools//third_party/java/jdk/langtools:javac_jar)"],` because test fails for wrong reason `-Xbootclasspath/p is no longer a supported option.`
Prefix flag with a name otherwise it looks it up as class name and fails with Caused by: java.lang.ClassNotFoundException: test_expect_failure.compilers_jvm_flags.args.txt
liucijus
approved these changes
Feb 1, 2021
ittaiz
approved these changes
Feb 2, 2021
This was referenced Feb 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add missing
exit 1to make test actually fail.Had to remove
jvm_opts = ["-Xbootclasspath/p:$(location @bazel_tools//third_party/java/jdk/langtools:javac_jar)"],because test fails for wrong reason
-Xbootclasspath/p is no longer a supported option.Motivation
Tried to write a test using
action_should_fail_with_messageand couldn't make it fail with a wrong error message.