feat(specs2): remove scope and shoulds #1333
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removed usage of
shouldandnew Scopefrom specs2 tests.shouldclashes with an expectation in Specs2 v5.Scopeis no longer available in Specs2 v5.shouldcan be used in specs2 v5, however in test classes must extendExtendedBlockDsl, which is not available in v4. Making it cross-compatible for v4 and v5 would require to write a custom 'should' in the rules_scala repo, which is not great.I understand it is not great in terms of spec formulation, but I do not see a cleaner way for now.
Motivation
Prerequisite for scala3 support. Scala3 build requires specs2 v5.