Skip to content

Conversation

johnynek
Copy link
Contributor

unzip by default prints all the files. This creates a lot of noise for thrift targets.

@bazel-io
Copy link

Can one of the admins verify this patch?

@ianoc
Copy link
Contributor

ianoc commented Sep 13, 2016

LGTM

@johnynek johnynek merged commit 4b850ad into master Sep 14, 2016
@johnynek johnynek deleted the oscar/quiet_unzip branch September 14, 2016 00:16
petemounce pushed a commit to improbable-io/rules_scala that referenced this pull request Oct 20, 2016
* upstream/master:
  use strings rather than HOST/DATA_CFG
  Add cfg attribute on executable labels
  Switch to using shorter stack traces.
  Catch throwables from type errors
  make thrift targets quieter (bazel-contrib#94)
  Fix jvm_flag support (bazel-contrib#93)
  Make compile timing optional, with default false
  Update README.md
  Persistent/worker scala compiler (bazel-contrib#91)
  fix typo in README.md (bazel-contrib#89)
  Fix for thrift rule issue that manifests with remote repos (bazel-contrib#83)
  improve the deploy jar creation (bazel-contrib#85)
  Use bind's for twitter scrooge so local repo's can override scrooge and thrift versions (bazel-contrib#84)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants