Add remaining changes for bootstrap build on OpenBSD. #10567
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, add back a missing `else` directive that the previous commit deleted by accident.
aiuto
added
team-OSS
|
@aehlig can you take a look please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have tested these changes via a bootstrap build on OpenBSD 6.6-current (amd64 architecture). The resulting
bazelbinary appeared to work in some simple testing involvingcc_library,cc_binary,java_library, andjava_binary.Known issues/limitations:
Building a
java_binary's deploy JAR fails because thesinglejartool fails to build. I intend to investigate soon.Running Bazel requires a
--host_javabase=@local_jdk//:jdkflag.Sandboxing is unsupported.
This change, split out of the larger PR #10274, is part of the OpenBSD port in #10250. Most of the changes in that larger PR have already been committed via several smaller PRs (see the PRs linked from #10250). This PR collects the remaining changes.