Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Protobuf to 3.11.3 #286

Merged
merged 2 commits into from
Feb 27, 2020
Merged

Update Protobuf to 3.11.3 #286

merged 2 commits into from
Feb 27, 2020

Conversation

Yannic
Copy link
Contributor

@Yannic Yannic commented Feb 20, 2020

This should make rules_kotlin compatible with --incompatible_load_proto_rules_from_bzl.

https://buildkite.com/bazel/bazelisk-plus-incompatible-flags/builds/417#b46d72d2-c746-41b7-9251-b1227f9283c0/516

Copy link
Collaborator

@cgruber cgruber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thank you.

@cgruber cgruber merged commit 2896b0a into bazelbuild:master Feb 27, 2020
restingbull pushed a commit to restingbull/rules_kotlin that referenced this pull request Feb 28, 2020
* Update Protobuf to 3.11.3

This should make rules_kotlin compatible with --incompatible_load_proto_rules_from_bzl.

https://buildkite.com/bazel/bazelisk-plus-incompatible-flags/builds/417#b46d72d2-c746-41b7-9251-b1227f9283c0/516

* That's what you get for editing files using GitHub's UI :/
cromwellian pushed a commit to cromwellian/rules_kotlin that referenced this pull request Mar 7, 2020
* Update Protobuf to 3.11.3

This should make rules_kotlin compatible with --incompatible_load_proto_rules_from_bzl.

https://buildkite.com/bazel/bazelisk-plus-incompatible-flags/builds/417#b46d72d2-c746-41b7-9251-b1227f9283c0/516

* That's what you get for editing files using GitHub's UI :/
@cgruber cgruber added this to In progress in Legacy 1.3.1 via automation Mar 12, 2020
@cgruber cgruber moved this from In progress to Done in Legacy 1.3.1 Mar 12, 2020
cgruber added a commit to cgruber/rules_kotlin that referenced this pull request Apr 14, 2020
* upstream/master:
  Fix non-reproducible archives (bazelbuild#304)
  Adds a kt_plugin rule (bazelbuild#308)
  Ensure that KotlionBuilder workers use a clean directory for each compilation. (bazelbuild#298)
  Apply autoformatting to all files. (bazelbuild#302)
  Optional outputs (bazelbuild#291)
  Change plugins to use depsets, as opposed to lists. (bazelbuild#292)
  Add Corbin to the codeowners. (bazelbuild#293)
  Update Protobuf to 3.11.3 (bazelbuild#286)
  Remove tree artifacts (bazelbuild#287)
  Cleanup src tree (bazelbuild#288)
  Update README.md (bazelbuild#285)
  Filter non-kotlin code out of generated sources (bazelbuild#263)
  Update readme so the dev instructions highlight using a local clone (bazelbuild#283)
  Remove third_party checked in jars, and properly pull maven dependencies. (bazelbuild#279)
  Only propagate srcjar if it isn't the default empty jar added in ae70089 to fix bazelbuild/intellij#1616 (bazelbuild#276)
  Allow resources to be in a kotlin directory (bazelbuild#268)
jongerrish added a commit to jongerrish/rules_kotlin that referenced this pull request Apr 16, 2020
* Update Protobuf to 3.11.3

This should make rules_kotlin compatible with --incompatible_load_proto_rules_from_bzl.

https://buildkite.com/bazel/bazelisk-plus-incompatible-flags/builds/417#b46d72d2-c746-41b7-9251-b1227f9283c0/516

* That's what you get for editing files using GitHub's UI :/
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Legacy 1.3.1
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants