Cleanup src tree #288
Merged
Cleanup src tree #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
February 24, 2020 11:24
…t, new location TBD
|
@googlebot I consent |
Merged
cgruber
approved these changes
Feb 27, 2020
| @@ -69,7 +67,7 @@ class CompilationTaskContext(val info: CompilationTaskInfo, private val out: Pri | |||
| out.println() | |||
| } | |||
|
|
|||
| inline fun <T> whenTracing(block: CompilationTaskContext.() -> T): T? { | |||
| fun <T> whenTracing(block: CompilationTaskContext.() -> T): T? { | |||
There was a problem hiding this comment.
Heh. This is where you ran into all those issues with the inline null, right?
Another way around it might have been to have a non-inlined function "nullify()" which returns null, which you call here. That way if it's inlined, the function call is inlined, not the bare "null".
But honestly, I don't think you're saving much by maintaining inlining, so this is fine.
| javaHome, | ||
| listOf( | ||
| kotlinCompilerJar, | ||
| BazelRunFiles.resolveVerified( |
|
This all looks great to me. Feel free to merge at your leisure. |
cromwellian
pushed a commit
to cromwellian/rules_kotlin
that referenced
this pull request
Mar 7, 2020
* Move CompilationTaskContext to toolchain, as it doesn't really belong in utils. * Move KotlinCompilerPluginArgsEncoder to toolchain. Temporary placement, new location TBD * Isolate the utils package * Move toolchain into a separate compilation unit. Causes some issues with inlining. * Split apart test packages. * Split apart test packages. * Split apart test packages. * add bazel version for development * factor out JvmCompilationTask extensions to reuse in abi generation * move compiler to source package. add .bazelversion for development
cgruber
added a commit
to cgruber/rules_kotlin
that referenced
this pull request
Apr 14, 2020
* upstream/master: Fix non-reproducible archives (bazelbuild#304) Adds a kt_plugin rule (bazelbuild#308) Ensure that KotlionBuilder workers use a clean directory for each compilation. (bazelbuild#298) Apply autoformatting to all files. (bazelbuild#302) Optional outputs (bazelbuild#291) Change plugins to use depsets, as opposed to lists. (bazelbuild#292) Add Corbin to the codeowners. (bazelbuild#293) Update Protobuf to 3.11.3 (bazelbuild#286) Remove tree artifacts (bazelbuild#287) Cleanup src tree (bazelbuild#288) Update README.md (bazelbuild#285) Filter non-kotlin code out of generated sources (bazelbuild#263) Update readme so the dev instructions highlight using a local clone (bazelbuild#283) Remove third_party checked in jars, and properly pull maven dependencies. (bazelbuild#279) Only propagate srcjar if it isn't the default empty jar added in ae70089 to fix bazelbuild/intellij#1616 (bazelbuild#276) Allow resources to be in a kotlin directory (bazelbuild#268)
jongerrish
added a commit
to jongerrish/rules_kotlin
that referenced
this pull request
Apr 16, 2020
* Move CompilationTaskContext to toolchain, as it doesn't really belong in utils. * Move KotlinCompilerPluginArgsEncoder to toolchain. Temporary placement, new location TBD * Isolate the utils package * Move toolchain into a separate compilation unit. Causes some issues with inlining. * Split apart test packages. * Split apart test packages. * Split apart test packages. * add bazel version for development * factor out JvmCompilationTask extensions to reuse in abi generation * move compiler to source package. add .bazelversion for development
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.