Ensure that KotlionBuilder workers use a clean directory for each compilation. #298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
restingbull
changed the title
cgruber
requested changes
Mar 12, 2020
src/main/kotlin/io/bazel/kotlin/builder/KotlinBuilderComponent.java
Outdated
Show resolved
Hide resolved
src/main/kotlin/io/bazel/kotlin/builder/toolchain/CompilationTaskContext.kt
Show resolved
Hide resolved
src/main/kotlin/io/bazel/kotlin/builder/utils/WorkingDirectoryContext.kt
Show resolved
Hide resolved
src/test/kotlin/io/bazel/kotlin/builder/KotlinAbstractTestBuilder.java
Outdated
Show resolved
Hide resolved
cgruber
added
component: android
component: jvm
P1
status: in review
restingbull
force-pushed
the
deterministic
branch
2 times, most recently
from
531c40e
to
6631e40
Compare
cgruber
approved these changes
Apr 2, 2020
added 4 commits
April 3, 2020 11:41
…e hermetic compilation.
* Restructured BazelWorker.kt for easier testing by pulling out the delegation invoker. * Changed the flag enums to be pulic and static. * Create KotlinBuilderTestComponent for retrieving configured instances for test. * Replaced the use of system user.dir with a more robust path usage.
Revert intellij overenthusiasm.
restingbull
force-pushed
the
deterministic
branch
from
6631e40
to
8391491
Compare
cgruber
added a commit
to cgruber/rules_kotlin
that referenced
this pull request
Apr 14, 2020
* upstream/master: Fix non-reproducible archives (bazelbuild#304) Adds a kt_plugin rule (bazelbuild#308) Ensure that KotlionBuilder workers use a clean directory for each compilation. (bazelbuild#298) Apply autoformatting to all files. (bazelbuild#302) Optional outputs (bazelbuild#291) Change plugins to use depsets, as opposed to lists. (bazelbuild#292) Add Corbin to the codeowners. (bazelbuild#293) Update Protobuf to 3.11.3 (bazelbuild#286) Remove tree artifacts (bazelbuild#287) Cleanup src tree (bazelbuild#288) Update README.md (bazelbuild#285) Filter non-kotlin code out of generated sources (bazelbuild#263) Update readme so the dev instructions highlight using a local clone (bazelbuild#283) Remove third_party checked in jars, and properly pull maven dependencies. (bazelbuild#279) Only propagate srcjar if it isn't the default empty jar added in ae70089 to fix bazelbuild/intellij#1616 (bazelbuild#276) Allow resources to be in a kotlin directory (bazelbuild#268)
jongerrish
added a commit
to jongerrish/rules_kotlin
that referenced
this pull request
Apr 16, 2020
…pilation. (bazelbuild#298) * Create WorkingDirectoryContext to handle compilation directory lifecycle. * Thread the working directory to all intermediate directories to ensure hermetic compilation. * Added test for worker hermiticity. * Restructured BazelWorker.kt for easier testing by pulling out the delegation invoker. * Changed the flag enums to be public and static. * Create KotlinBuilderTestComponent for retrieving configured instances for test. * Replaced the use of system user.dir with a more robust path usage. * Ensure js has a clean working area.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.