Allow resources to be in a kotlin directory #268
Conversation
We just put everything in a `kotlin` directory (which the test rules allow for) so it'd be nice if resources also didn't need this prefix.
rockwotj
requested review from
cgruber,
djwhang,
git-str,
jin,
thomaswk and
timpeut
as code owners
|
Do you put them in "/kotlin" or do you mean "src/main/kotlin"? I'm a little hesitant to just make "kotlin" the split as it's not the most uncommon package name which could result in some bad (and breaking) source root inferences. I'd be more comfortable breaking on src/kotlin or src/*/kotlin. |
cgruber
added
component: android
component: jvm
P3
status: open - investigating
type: enhancement
|
I put them in rules_kotlin/kotlin/internal/jvm/impl.bzl Lines 157 to 164 in 4512a83 In general I'm not a fan of the unneeded maven structure of separating sources and tests. I understand you can specify a prefix per binary, but we have many binaries and specifying the strip resource prefix is... annoying. |
|
Ahhh. I'm sorry, I get it now. I realize I had made the change I was thinking about already, and you're expanding it. I apparently can't read a simple diff. :/ This is fine. |
* Allow resources to be in a kotlin directory We just put everything in a `kotlin` directory (which the test rules allow for) so it'd be nice if resources also didn't need this prefix. * Update docs
* upstream/master: Fix non-reproducible archives (bazelbuild#304) Adds a kt_plugin rule (bazelbuild#308) Ensure that KotlionBuilder workers use a clean directory for each compilation. (bazelbuild#298) Apply autoformatting to all files. (bazelbuild#302) Optional outputs (bazelbuild#291) Change plugins to use depsets, as opposed to lists. (bazelbuild#292) Add Corbin to the codeowners. (bazelbuild#293) Update Protobuf to 3.11.3 (bazelbuild#286) Remove tree artifacts (bazelbuild#287) Cleanup src tree (bazelbuild#288) Update README.md (bazelbuild#285) Filter non-kotlin code out of generated sources (bazelbuild#263) Update readme so the dev instructions highlight using a local clone (bazelbuild#283) Remove third_party checked in jars, and properly pull maven dependencies. (bazelbuild#279) Only propagate srcjar if it isn't the default empty jar added in ae70089 to fix bazelbuild/intellij#1616 (bazelbuild#276) Allow resources to be in a kotlin directory (bazelbuild#268)
* Allow resources to be in a kotlin directory We just put everything in a `kotlin` directory (which the test rules allow for) so it'd be nice if resources also didn't need this prefix. * Update docs
We just put everything in a
kotlindirectory (which the test rules allow for) so it'd be nice if resources also didn't need this prefix.This change is