Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Directories in tree artifacts are written to tar files with mode 644 instead of 755 #612

Closed
aiuto opened this issue Sep 2, 2022 · 0 comments
Closed

Directories in tree artifacts are written to tar files with mode 644 instead of 755 #612

aiuto opened this issue Sep 2, 2022 · 0 comments
Assignees
@aiuto
Labels
bug P1 An issue that must be resolved. Must have an assignee

Comments

@aiuto
Copy link
Collaborator

aiuto commented Sep 2, 2022 •
edited
Loading

Intermediare directories in tree artifacts get written with the wrong permissions in pkg_tar.
They end up as 644 rather than 755, rendering them unreadable.

The fix might be as simple as:

pkg/private/tar/build_tar.py
268c268
<             mode=f_mode,
---
>             mode=0o755,
@aiuto aiuto added bug P1 An issue that must be resolved. Must have an assignee labels Sep 2, 2022
@aiuto aiuto self-assigned this Sep 2, 2022
aiuto added a commit to aiuto/rules_pkg that referenced this issue Sep 2, 2022
@aiuto
fix bazelbuild#612
52e5da6
@aiuto aiuto closed this as completed in 5b8a851 Sep 2, 2022
@aiuto aiuto mentioned this issue Sep 8, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aiuto aiuto

Labels
bug P1 An issue that must be resolved. Must have an assignee
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@aiuto