Skip to content

Correct documented type of CrateInfo.aliases field (dict key type is Target, not Label) #3598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 27, 2025
Merged

Correct documented type of CrateInfo.aliases field (dict key type is Target, not Label) #3598

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
493983f
Correct listed type (Dict[Target, String] rather than Dict[Label, Str…
bmoxb Sep 8, 2025
19d3606
Merge branch 'main' into crate_info_aliases_type
illicitonion Sep 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion rust/private/providers.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
CrateInfo = provider(
doc = "A provider containing general Crate information.",
fields = {
"aliases": "Dict[Label, String]: Renamed and aliased crates",
"aliases": "Dict[Target, String]: Renamed and aliased crates",
"cfgs": (
"List[str]: The set of enabled cfgs for this crate. Note that this field is populated only " +
"when @rules_rust//rust/settings:collect_cfgs is set."
Expand Down