Use apple constraints over config_setting_group in select #1563
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The intent of @apple_support//configs:apple is to provide a way for users to select on whether the current platform is an apple one or not. It does that by iterating over APPLE_PLATFORMS_CONSTRAINTS, and checking whether the "cpus" is one of the apple known CPUs. This works in the general case, but in the exceptional case where the user wants to define custom apple platforms, it is a problem. So in this patchset we're switching to using the constraint directly over the config_setting_group(). It should be a functional no-op for the general case, but it provides more flexibility if case the user needs a higher degree of customization.
ma-oli
requested review from
aaronsky,
BalestraPatrick,
brentleyjones,
keith,
luispadron,
mattrobmattrob and
thii
as code owners
keith
approved these changes
Aug 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The intent of @apple_support//configs:apple is to provide a way for users to select on whether the current platform is an apple one or not.
It does that by iterating over APPLE_PLATFORMS_CONSTRAINTS, and checking whether the "cpus" is one of the apple known CPUs. This works in the general case, but in the exceptional case where the user wants to define custom apple platforms, it is a problem.
So in this patchset we're switching to using the constraint directly over the config_setting_group(). It should be a functional no-op for the general case, but it provides more flexibility if case the user needs a higher degree of customization.