Skip to content

Test enhancement #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 7, 2018
Merged

Conversation

peter279k
Copy link
Collaborator

Changed log

  • Let the package require PHP >=5.6 version.
  • Remove the additional space.
  • Add the php-nightly test in Travis CI build and let this allow failure.
    We don't guarantee that the php-nightly test will always be successful.
  • Set the different PHPUnit version to support multiple PHP versions.
  • Using the class-based PHPUnit namespace to be compatible with the latest stable PHPUnit version.

@peter279k
Copy link
Collaborator Author

@stevleibelt, can you concern about this PR?

Thanks.

@stevleibelt
Copy link
Member

Hey @peter279k,

thanks for your pull request and for your follow up.

Your pull request is perfect and I am totally ashamed of the whitespaces :-D.

@stevleibelt stevleibelt merged commit d2d282c into bazzline:master Nov 7, 2018
@stevleibelt
Copy link
Member

Now I need to add a contribution section 👍

@peter279k peter279k deleted the test_enhancement branch November 8, 2018 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants