Fixing Firefox and IE8 compatibility issues

[thom4parisot]

We now have a fully covered unit testing for:

• Safari 6 (OS X)
• Mobile Safari (iOS 5.1)
• Android Stock Browser (Android 4.0)
• Firefox 21 (Windows 7)
• Internet Explorer 8 (Windows 7)

This is the result of the following PR:

• IE8, Safari, Mobile Safari, Firefox and Android Continuous Integration unit testing #70 Sauce Remote Testing
• [READY] Gecko Compatibility #72 Gecko Compatibility
• [READY] Internet Explorer 8 Features Compatibility #73 Internet Explorer 8 Features Compatibility (this is the resubmitted [READY] Doesn't work in IE8 #62 PR)
• [READY] IE8 Compatible Unit Testing #74 IE8 Compatible Unit Testing

They have been merged in the browsers-compatibility branch first.
Secured data are not pushed in PR incoming from forks.

If the Travis badge is failing for this PR, consider this build as a reference:

https://travis-ci.org/BBC-News/Imager.js/builds/17475266

[Integralist]

@oncletom just a couple of quick observations...

    addEvent = (function(){
        if (document.addEventListener){
            return function addStandartEventLister(el, eventName, fn){
                return el.addEventListener(eventName, fn, false);
            };
        }
        else {
            return function addIEEventListener(el, eventName, fn){
                return el.attachEvent('on'+eventName, fn);
            };
        }
    })();

addStandartEventLister should probably be addStandardEventListener

Also, later on when you use the addEvent method you do...

addEvent(window, 'resize', function(){
    self.checkImagesNeedReplacing(self.divs);
}, false);

...you can see you pass in false but you use that by default within addStandartEventLister any way, so I'd assume we can lose the 4th argument false from the addEvent call.

[Integralist]

@oncletom otherwise it looks good.

[thom4parisot]

@Integralist oh well spotted, true. Fixed, thanks :-)