Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libmfx/cmake: use gnuinstalldirs and don't limit pkg-config generation #47

Merged
merged 2 commits into from
Oct 11, 2023

Conversation

1480c1
Copy link
Contributor

@1480c1 1480c1 commented Oct 10, 2023

BBC-archive/libMXF#6
BBC-archive/libMXF#7

Also allows the end user to install the binaries to a different location. Example being -DCMAKE_INSTALL_BINDIR=bin-video.
More info available at https://cmake.org/cmake/help/v3.12/module/GNUInstallDirs.html

Makes it so that it generates the .pc file when using non-unix systems like with mingw-w64 cmake from msys2.

Also allows the end user to install the binaries to a different location.
Example being -DCMAKE_INSTALL_BINDIR=bin-video.

Signed-off-by: Christopher Degawa <ccom@randomderp.com>
Windows (especially when using mingw-w64) and others can still use a
.pc file. An alternative check would be to see if
find_package(PkgConfig OPTIONAL) fails and then not generate the .pc.
However, causing the build results to differ isn't always wanted.

Signed-off-by: Christopher Degawa <ccom@randomderp.com>
@1480c1 1480c1 changed the title cmake: use gnuinstalldirs and don't limit pkg-config generation libmfx/cmake: use gnuinstalldirs and don't limit pkg-config generation Oct 10, 2023
@philipnbbc philipnbbc self-requested a review October 11, 2023 08:00
Copy link
Collaborator

@philipnbbc philipnbbc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@philipnbbc philipnbbc merged commit ffb8098 into bbc:main Oct 11, 2023
5 checks passed
@1480c1 1480c1 deleted the cmake/mingw64/pkgconf branch November 10, 2023 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants