Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial setting of state (null/ready/paused/playing) for each input/output/mixer #3

Merged
merged 3 commits into from
Nov 6, 2018

Conversation

matthew1000
Copy link
Collaborator

@matthew1000 matthew1000 commented Nov 6, 2018

Addresses four ares:

  1. Allows the user to specify what state a newly created input/output/mixer is. Previously, all would start PLAYING. Now, an ‘initial_state’ property can allow it to be PAUSED or READY (or even NULL, if somehow that's wanted).
  2. Stops a race condition where an input can enter PLAYING before the bus has initialised, which resulted in some events being missed and thus certain elements not being unblocked.
  3. Removes an anomaly where the RTMP output would enter PAUSED rather than PLAYING.
  4. Documents the config file.
  • tests pass
  • linting passes
  • test written

@moschopsuk moschopsuk added this to the 1.1.0 milestone Nov 6, 2018
@matthew1000 matthew1000 merged commit c693490 into master Nov 6, 2018
@moschopsuk moschopsuk deleted the initial_state_setting branch November 19, 2018 09:18
alebcay referenced this pull request in alebcay/brave Mar 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants