Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Additional colours #2

Merged
merged 5 commits into from
May 15, 2019
Merged

Additional colours #2

merged 5 commits into from
May 15, 2019

Conversation

alecsIV
Copy link
Contributor

@alecsIV alecsIV commented May 14, 2019

Added additional colours used in eu parliament scoreboard

@alecsIV
Additional colours
a61b197 
Added additional colours used in eu parliament scoreboard
Ramish9000
Ramish9000 approved these changes May 15, 2019
View reviewed changes
Copy link
Contributor

@Ramish9000 Ramish9000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@EdwardLuke
Copy link
Member

EdwardLuke commented May 15, 2019 •
edited
Loading

I realise this goes against convention but my feeling is that semantic names for the colours would be more useful - e.g. I would happily reuse these colours if I knew what they were meant to be used for!

If we decide to stick to convention I'll go ahead and merge this PR.

@alecsIV
Copy link
Contributor Author

alecsIV commented May 15, 2019 •
edited
Loading

I realise this goes against convention but my feeling is that semantic names for the colours would be more useful - e.g. I would happily reuse these colours if I knew what they were meant to be used for!

@EdwardLuke7
Yeah, I agree it would make more sense if they had more 'project-related' names, if I can't find any other reference to them in either Grandstand or sass-tools, I could probably change their names to reflect what they are actually used for.

@alecsIV alecsIV merged commit cfd1594 into master May 15, 2019
@alecsIV alecsIV deleted the additional-colours-import branch May 15, 2019 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EdwardLuke EdwardLuke EdwardLuke approved these changes

@Ramish9000 Ramish9000 Ramish9000 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alecsIV @EdwardLuke @Ramish9000