Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regenerate static files #6

Merged
merged 1 commit into from
Nov 9, 2023
Merged

Regenerate static files #6

merged 1 commit into from
Nov 9, 2023

Conversation

samdbmg
Copy link
Member

@samdbmg samdbmg commented Nov 9, 2023

Details

Regenerate the static Makefiles to pick up a change to the wheel build targets

Pivotal Story

Story URL: Part of https://www.pivotaltracker.com/story/show/186363984

Related PRs

Arises from https://github.com/bbc/rd-cloudfit-commontooling/pull/272

Links to external test runs/working deployment

N/A

Submitter PR Checks

(tick as appropriate)

  • Added bbc/rd-apmm-cloudfit team as a reviewer
  • PR completes task/fixes bug
  • Tests exercise code appropriately
  • New features and API breaks are flagged in commit messages using magic strings
  • Repo maintainer is notified that a release is required
  • Documentation updated (README, Confluence, Docstrings, API spec, Engineering Guide, etc.)
  • Downstream repos have been checked for potential breaks & fixed as needed
  • APIs/UIs/CLIs updated as required
  • PR added to Pivotal story
  • Follow-up stories added to Pivotal
  • Any temporary code/configuration removed (e.g. test deployment environment, temporary commontooling branch)
  • Any pins against pre-releases have been removed

Reviewer PR Checks

(tick as appropriate)

  • PR completes task/fixes bug
  • Tests exercise code appropriately
  • Design makes sense, and fits with our current code base
  • Code is easy to follow
  • PR size is sensible
  • Commit history is sensible and tidy

Info on Cloudfit PRs

@samdbmg samdbmg requested a review from a team November 9, 2023 11:08
@samdbmg samdbmg merged commit afa800a into main Nov 9, 2023
8 checks passed
@samdbmg samdbmg deleted the sammg-update-wheel-command branch November 9, 2023 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants