Make focusable container logic opt in #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changing the focusable container functionality from being the default to being opt in via a
data-lrud-consider-container-distanceattribute.Motivation and Context
The focusable containers has proven to be not needed more often than it is, and we often bump into scenarios where focusing containers is unintuitive and doesn't 'feel' right.
Keeping the behaviour around as there are scenarios we do want it, but opting in to it.
How Has This Been Tested?
Refactored the tests, replaced some of the test files with ones that are less specific to our use case and replicate the bare minimum scenario. Added new tests around focusable container behaviour (all the other tests are testing unfocusable containers implicitly).
Checklist: