Calculate container corners for validate candidates #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Murray Coghill <Murreey@users.noreply.github.com>
… a valid candidate & the position of the container
jordanholt
approved these changes
Aug 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Consider the position of a valid container corners when calculating the best container move to.
Motivation and Context
When there are multiple small containers that overlap each other in rows, a container that was at the end of the row could skip the row above/below and have some unexpected behaviour moves.
For example pressing right at 22 would skip 15 and go to 8. Now with this fix, a right press from 22 goes to 15 as it now considers the corners of candidates. It considers the exit direction you are leaving a container, and if a candidates corners are within that side. So as 15's right corners are to the right of the leaving container (22) it is a valid candidate to move to.
How Has This Been Tested?
Added a new test case and existing test pass.
Checklist: