Don't stop npm install if Husky fails
#30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Likely due to not being at the root of the repo, for example if being installed in a subproject of a monorepo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Likely due to not being at the root of the repo, for example if being installed in a subproject of a monorepo
Motivation and Context
Fixes #29; this was causing issues trying to use the new version in EPT. Similar approach for this problem used in BSP: https://github.com/bbc/bigscreen-player/blob/master/package.json#L15
How Has This Been Tested?
Ran
npm installin and outside of a repo context (Deleted.git), completes successfully in both cases, and Git Hooks are installed inside the repo context.Checklist: