Refactor upstream timing capability #19
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add the ability to configure which response header to consider when processing the
upstream_duration
value and provide a simpleDate
-based fallback if this is not available.Since existing v1 consumers may be reliant on the "default" header being used, this would incur a breaking change.
Motivation and Context
In v1, an assumption was made that responses would contain a header with the key
x-response-time
to be used as the upstream duration. We would like to have the ability to configure this header or alternatively calculate this manually.How Has This Been Tested?
New unit tests added.
Types of changes
Checklist: