Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve code quality #25

Merged
merged 22 commits into from
Feb 28, 2020
Merged

Improve code quality #25

merged 22 commits into from
Feb 28, 2020

Conversation

epatrasc
Copy link
Contributor

@epatrasc epatrasc commented Feb 21, 2020 •
edited
Loading

Description

Improve code quality adding proper linting with typescript support and removing unused dependencies.

Motivation and Context

We want a clean and error free library.

How Has This Been Tested?

Automated tests.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

No versioning required.

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@epatrasc epatrasc requested a review from a team as a code owner February 21, 2020 10:41
@epatrasc epatrasc merged commit fff7ae9 into master Feb 28, 2020
@epatrasc epatrasc deleted the code-quality branch February 28, 2020 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jordanholt jordanholt jordanholt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@epatrasc @jordanholt