Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds tests for 302 and 303 redirects #35

Merged
merged 1 commit into from
Jul 16, 2020
Merged

Adds tests for 302 and 303 redirects #35

merged 1 commit into from
Jul 16, 2020

Conversation

dwalees
Copy link
Member

@dwalees dwalees commented Jul 16, 2020

Description

Adds tests for 302 and 303 redirects to ensure these are being handled correctly.

Motivation and Context

We wish to use 303 responses in one of our services which uses melchett. Adding these tests to ensure that these responses are handled well.

How Has This Been Tested?

Running the endtoend tests.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@dwalees dwalees requested a review from a team as a code owner July 16, 2020 12:47
@dwalees dwalees merged commit 4efe5b4 into master Jul 16, 2020
@dwalees dwalees deleted the redirect-tests branch July 16, 2020 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants