make the next() call from within the circuit breaker action
#38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 24, 2020 13:42
fixes #18 Without this it's possible for the code run by `next` to throw, and this would not be considered in the circuit breaker calculations. This change also means that some opossum options like `options.capacity` will now function correctly.
jordanholt
approved these changes
Jul 24, 2020
|
@tjenkinson Merge when you're ready and I'll version and publish for you. |
|
@jordanholt thanks. merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Without this it's possible for the code run by
nextto throw, and this would not be considered in the circuit breaker calculations. This change also means that some opossum options likeoptions.capacitywill now function correctly.Motivation and Context
fixes #18
How Has This Been Tested?
With the unit tests.
Types of changes
Checklist: