Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WSTEAMA-221-Message Banner is displayed on live topic pages #10701

Merged
merged 4 commits into from
Mar 14, 2023

Conversation

holchris
Copy link
Contributor

@holchris holchris commented Mar 13, 2023

Resolves JIRA [WSTEAMA-221]

Overall changes

Message Banner is displayed on live topic pages

  • edited unit tests

Code changes

Removes isLive check to go live and associated tests

Testing

Ran unit tests and all passed

Helpful Links

Add Links to useful resources related to this PR if applicable.

Coding Standards

Repository use guidelines

@@ -28,10 +28,6 @@ const MessageBanner = ({
const { dir } = useContext(ServiceContext);
const isRtl = dir === 'rtl';

if (isLive()) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also remove the import on line 4. 🙏

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This is now fixed

@pvaliani pvaliani self-requested a review March 14, 2023 10:40
Copy link
Contributor

@pvaliani pvaliani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, well done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants