Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uploader Success Page: Add outline none to header #11696

Merged
merged 2 commits into from
Jun 4, 2024

Conversation

Isabella-Mitchell
Copy link
Contributor

@Isabella-Mitchell Isabella-Mitchell commented Jun 4, 2024

Resolves JIRA N/A

Overall changes

Ensures outline does not appear around Heading on form Success page (to match default form page)

Code changes

Adds outline none styling to H1 on focus state.

Testing

Open storybook UGC permalink
Use the Skip to content link in the brand
Ensure outline does not appear around heading

Helpful Links

Add Links to useful resources related to this PR if applicable.

Coding Standards

Repository use guidelines

@Isabella-Mitchell Isabella-Mitchell marked this pull request as ready for review June 4, 2024 07:56
Copy link

@greenc05 greenc05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hurrah, thanks @Isabella-Mitchell

@Isabella-Mitchell Isabella-Mitchell merged commit 9baff4b into latest Jun 4, 2024
11 checks passed
@Isabella-Mitchell Isabella-Mitchell deleted the A11y-fix-outline-none branch June 4, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants