Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to Indian and Ukranian navigation bars #11730

Merged
merged 3 commits into from
Jun 17, 2024
Merged

Conversation

jordit
Copy link
Contributor

@jordit jordit commented Jun 17, 2024

Resolves JIRA [number]

Overall changes

  • Remove election topic links to the navgation bar of Gujarati, Hindi, Marathi, Punjanbi and Telugu
  • Replaced election topic with T20 WC on Tamil's nav bar
  • Added Euro 2024 to Ukrainian's navbar

======

  • Edited Navigation section of src/app/lib/config/services/gujarati.ts to remove election topic
  • Edited Navigation section of src/app/lib/config/services/hindi.ts to remove election topic
  • Edited Navigation section of src/app/lib/config/services/marathi.ts to remove election topic
  • Edited Navigation section of src/app/lib/config/services/punjabi.ts to remove election topic
  • Edited Navigation section of src/app/lib/config/services/tamil.ts to replace election topic link with T20 WC topic
  • Edited Navigation section of src/app/lib/config/services/telugu.ts to remove election topic
  • Edited Navigation section of src/app/lib/config/services/ukrainian.ts to add Euro 2024 at the end
  • Updated snapshots

Testing

  1. Open the Gujarati, Hindi, Marathi, Punjabi and Telugu front page there should be no election topic link in second position
  2. Open the Tamil front page the second link in the nav should open /tamil/topics/c1nqez19x01t
  3. Open the Ukrainian front page the last link in the nav should open /ukrainian/topics/ckvv0w1kqnzt

Helpful Links

Add Links to useful resources related to this PR if applicable.

Coding Standards

Repository use guidelines

@jordit
Copy link
Contributor Author

jordit commented Jun 17, 2024

thanks @karinathomasbbc

@jordit jordit merged commit 145fcea into latest Jun 17, 2024
11 checks passed
@jordit jordit deleted the update-indian-and-uk-navs branch June 17, 2024 11:07
@jordit
Copy link
Contributor Author

jordit commented Jun 17, 2024

Thanks @HarveyPeachey

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants