Ondemand audio (Radio and Podcasts) - Remove tests (Unit, integration and E2E) against AMP versions of these pages

cypress/e2e/pages/onDemandAudio/index.cy.js

@@ -1,9 +1,7 @@
 import config from '../../../support/config/services';
 import getPaths from '../../../support/helpers/getPaths';
 import serviceHasPageType from '../../../support/helpers/serviceHasPageType';
-import testsForCanonicalOnly from './testsForCanonicalOnly';
-import testsForAMPOnly from './testsForAMPOnly';
-import crossPlatformTests from './tests';
+import e2eTests from './tests';
 import visitPage from '../../../support/helpers/visitPage';
 import { overrideRendererOnTest } from '../../../support/helpers/onDemandRadioTv';
 
@@ -24,37 +22,11 @@ Object.keys(config)
 
           visitPage(newPath, pageType);
         });
-        crossPlatformTests({
-          service,
-          pageType,
-          variant,
-        });
-        testsForCanonicalOnly({
+        e2eTests({
           service,
           pageType,
           variant,
         });
       });
     });
-    paths
-      .map(path => `${path}.amp`)
-      .forEach(currentPath => {
-        describe(`${pageType} - ${currentPath}`, () => {
-          before(() => {
-            Cypress.env('currentPath', currentPath);
-            visitPage(currentPath, pageType);
-          });
-          crossPlatformTests({
-            service,
-            pageType,
-            variant,
-            isAmp: true,
-          });
-          testsForAMPOnly({
-            service,
-            pageType,
-            variant,
-          });
-        });
-      });
   });

cypress/e2e/pages/onDemandAudio/tests.js

@@ -11,8 +11,12 @@ import envConfig from '../../../support/config/envs';
 import appConfig from '../../../../src/server/utilities/serviceConfigs';
 import getDataUrl from '../../../support/helpers/getDataUrl';
 import processRecentEpisodes from '../../../../src/app/routes/utils/processRecentEpisodes';
+import {
+  isScheduleDataComplete,
+  getIsProgramValid,
+} from '../../../../src/app/legacy/containers/RadioSchedule/utilities/evaluateScheduleData';
 
-export default ({ service, pageType, variant, isAmp }) => {
+export default ({ service, pageType, variant }) => {
   describe(`Tests for ${service} ${pageType}`, () => {
     describe(
       'Audio Player',
@@ -30,7 +34,7 @@ export default ({ service, pageType, variant, isAmp }) => {
               );
             }
             const language = appConfig[service][variant].lang;
-            const embedUrl = getEmbedUrl({ body: jsonData, language, isAmp });
+            const embedUrl = getEmbedUrl({ body: jsonData, language });
             const isBrandPage = isBrand(jsonData);
 
             cy.get('iframe').then(iframe => {
@@ -132,7 +136,6 @@ export default ({ service, pageType, variant, isAmp }) => {
                     convertTimestampsToLocaleString(processedEpisodesData);
 
                   const simorghJsonResWithLocaleStringTimestamp =
-                    !isAmp &&
                     convertTimestampsToLocaleString(
                       win.SIMORGH_DATA.pageData.recentEpisodes,
                     );
@@ -147,12 +150,12 @@ export default ({ service, pageType, variant, isAmp }) => {
                       JSON.stringify(cypressJsonResWithLocaleStringTimestamp),
                     );
                     cy.log('HTML on page - ', renderedEpisodesInnerText);
-                    if (!isAmp) {
-                      cy.log(
-                        'Simorgh json response - ',
-                        JSON.stringify(simorghJsonResWithLocaleStringTimestamp),
-                      );
-                    }
+
+                    cy.log(
+                      'Simorgh json response - ',
+                      JSON.stringify(simorghJsonResWithLocaleStringTimestamp),
+                    );
+
                     /* eslint-enable no-console */
                   }
 
@@ -200,6 +203,68 @@ export default ({ service, pageType, variant, isAmp }) => {
           });
         });
       });
+      describe('Radio Schedule', () => {
+        it('should be displayed if there is enough schedule data', function test() {
+          const currentPath = `${Cypress.env(
+            'currentPath',
+          )}.json${overrideRendererOnTest()}`;
+
+          cy.request(currentPath).then(({ body: jsonData }) => {
+            cy.fixture(`toggles/${service}.json`).then(toggles => {
+              const scheduleIsEnabled = path(
+                ['onDemandRadioSchedule', 'enabled'],
+                toggles,
+              );
+              cy.log(
+                `On Demand Radio Page configured for Radio Schedule? ${scheduleIsEnabled}`,
+              );
+
+              if (scheduleIsEnabled) {
+                const masterBrand = jsonData.metadata.createdBy;
+
+                const schedulePath =
+                  `/${service}/${masterBrand}/schedule.json${overrideRendererOnTest()}`.replace(
+                    'bbc_afaanoromoo_radio',
+                    'bbc_oromo_radio',
+                  );
+
+                cy.request(schedulePath).then(({ body: scheduleJson }) => {
+                  const { schedules } = scheduleJson;
+                  const isProgramValid = getIsProgramValid(() => {});
+                  const validSchedules = schedules.filter(isProgramValid);
+
+                  const isRadioScheduleDataComplete = isScheduleDataComplete({
+                    schedules: validSchedules,
+                  });
+
+                  cy.log(
+                    `Radio Schedule is displayed? ${isRadioScheduleDataComplete}`,
+                  );
+                  if (scheduleIsEnabled && isRadioScheduleDataComplete) {
+                    cy.log('Schedule has enough data');
+                    cy.get('[data-e2e=radio-schedule]').should('exist');
+                    // cy.get('[data-e2e=live]').should('exist');
+                  } else {
+                    cy.get('[data-e2e=radio-schedule]').should('not.exist');
+                  }
+                });
+              } else {
+                cy.get('[data-e2e=radio-schedule]').should('not.exist');
+              }
+            });
+          });
+        });
+      });
+    });
+    describe('Chartbeat', () => {
+      if (envConfig.chartbeatEnabled) {
+        it('should have a script with src value set to chartbeat source', () => {
+          cy.hasScriptWithChartbeatSrc();
+        });
+        it('should have chartbeat config set to window object', () => {
+          cy.hasGlobalChartbeatConfig();
+        });
+      }
     });
   });
 };

cypress/e2e/specialFeatures/cookieBanner/index.cy.js

@@ -39,6 +39,7 @@ const getPaths = service =>
   );
 
 const pageType = 'all';
+const urlsToExcludeFromAmpTests = ['_tv', '_radio'];
 
 Object.keys(config)
   .filter(service => serviceFilter(service))
@@ -57,7 +58,7 @@ Object.keys(config)
     paths
       .map(path => `${path}.amp`)
       .forEach(path => {
-        if (!path.includes('tv')) {
+        if (!urlsToExcludeFromAmpTests.some(url => path.includes(url))) {
           describeForEuOnly(`${path} - AMP Cookie Banner`, () => {
             beforeEach(() => {
               visitPage(path, pageType);

scripts/ampHtmlValidator/index.js

@@ -11,7 +11,6 @@ const pageTypes = [
   'liveRadio',
   'photoGalleryPage',
   'mostReadPage',
-  'onDemandAudio',
   'onDemandTV',
   'mediaAssetPage',
   'storyPage',

src/app/pages/OnDemandAudioPage/OnDemandAudioPage.jsx

@@ -11,7 +11,6 @@ import pathOr from 'ramda/src/pathOr';
 import useLocation from '#hooks/useLocation';
 import ComscoreAnalytics from '#containers/ComscoreAnalytics';
 import Grid, { GelPageGrid } from '#components/Grid';
-import { RequestContext } from '#contexts/RequestContext';
 import StyledRadioHeadingContainer from '#containers/OnDemandHeading/StyledRadioHeadingContainer';
 import OnDemandParagraphContainer from '#containers/OnDemandParagraph';
 import AVPlayer from '#containers/AVPlayer';
@@ -108,7 +107,6 @@ const OnDemandAudioPage = ({ pageData, mediaIsAvailable, MediaError }) => {
 
   const pageType = path(['metadata', 'type'], pageData);
 
-  const { isAmp } = useContext(RequestContext);
   const location = useLocation();
   const { dir, liveRadioOverrides, lang, service, translations, serviceName } =
     useContext(ServiceContext);
@@ -124,7 +122,6 @@ const OnDemandAudioPage = ({ pageData, mediaIsAvailable, MediaError }) => {
   const embedUrl = getEmbedUrl({
     mediaId,
     type: 'media',
-    isAmp,
     queryString: location.search,
   });