WSTEAM1-1050: Open CAF to all services #11805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/app/legacy/psammead/psammead-social-embed/src/CaptionWrapper/index.jsx
Outdated
Show resolved
Hide resolved
shayneahchoon
force-pushed
the
WSTEAM1-1050
branch
from
cbddadc
to
ca45005
Compare
shayneahchoon
changed the title
amoore108
approved these changes
Aug 1, 2024
There was a problem hiding this comment.
Looks great 👍
There are a couple of changes in snapshots relating to SEO. However they appear to be mostly isolated to extremely old TC2 content, so I don't think its a major concern.
The others look minor and more inline with expected differences when rendering the asset through the ArticlePage component instead of its older page component.
I'd advise trying this out on Preview once reviewed, then we can test it on Test and run the E2E's against it. If its all good then it feels safe to go to Live.
Isabella-Mitchell
approved these changes
Aug 1, 2024
amoore108
added a commit
that referenced
this pull request
Aug 7, 2024
)" This reverts commit db1e473.
amoore108
added a commit
that referenced
this pull request
Aug 7, 2024
…AF rendering on all services) (#11821) * Revert "Revert "WSTEAM1-1050: Open CAF to all services (#11805)" (#11820)" This reverts commit db1e473. * [DNM] Remove Welsh service transform logic (#11818) * Remove `table` component E2E checks (#11819) * Remove `table` component E2E check * Update testsForAMPOnly.js * CPS recommendation block CAF styling fix (#11822)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves JIRA WSTEAM1-1050
Overall changes
Removes isCaf flag in Simorgh. Following this change all Story, Media Asset and Photo Gallery requests will come through CAF and be rendered through their respective updated page types.
Code changes
Testing
Helpful Links
Add Links to useful resources related to this PR if applicable.
Coding Standards
Repository use guidelines