-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Differential serving using module/nomodule scripts #9584
Conversation
27532c4
to
8532228
Compare
8532228
to
a643b16
Compare
a65371e
to
f7b43de
Compare
…into modern-legacy-bundles
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great 👍🏼 It'll be interesting to see the effect this will have on our performance metrics. Is it worth capturing or referencing benchmarks before these changes are implemented and then capturing some afterwards?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@amoore108 we have a couple of tools for monitoring performance. We have both real user measurements and synthetic tests running daily. I was planning on looking at this data. Is there any other method of measuring performance you think would be useful? |
That sounds good to me! Just wanted to check if we were capturing any comparison data before merge 😄 |
Resolves #7155
Overall change:
Simorgh now builds 2 client side JavaScript bundles. A slimmer modern bundle for modern browsers and a (currently live) bloated bundle for legacy browsers.
The modern bundle is transpiled to ES2017 syntax and legacy bundle is transpiled to ES5.
More info in the docs
Code changes:
cross-team
label to this PR if it requires visibility across World Service teamsTesting:
Requires full cross-browser regression testing.
To test please run
yarn build && yarn start
CYPRESS_APP_ENV=local CYPRESS_SMOKE=false yarn test:e2e:interactive
)